[
https://issues.apache.org/jira/browse/CALCITE-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604888#comment-16604888
]
Julian Hyde commented on CALCITE-2523:
--------------------------------------
Rubbish. All tests' "computations are exactly the same every time". Except when
they're not, because someone has changed the code, and the test breaks. That's
the point of a test.
I'm getting fed up over the amount of time we've spent on this issue (and other
issues that are about developer convenience, that do not make the product
better for end users). I have finite time to spend on Calcite, and you have
used up much of it.
> PartiallyOrderedSetTest#testPosetBitsLarge takes ~80 seconds at Travis
> ----------------------------------------------------------------------
>
> Key: CALCITE-2523
> URL: https://issues.apache.org/jira/browse/CALCITE-2523
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.18.0
>
>
> PartiallyOrderedSetTest#testPosetBitsLarge is quite large, and it performs
> exactly the same computation during test execution.
> I suggest to guard the test like {{testPosetBitsLarge2}} with ENABLE_SLOW:
> {code:java}Assume.assumeTrue("too slow to run every day",
> CalciteAssert.ENABLE_SLOW);{code}
> Alternative options: reduce test complexity to make it faster, and/or
> randomize test execution so it explores new test cases on every execution.
> For instance, it could run for 5 seconds and explore new cases each time.
> Current test is more or less useless, and it does take noticeable CI time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
