[ 
https://issues.apache.org/jira/browse/CALCITE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632231#comment-16632231
 ] 

Julian Hyde commented on CALCITE-2510:
--------------------------------------

I did an initial review. It looks OK:
* Is it necessary to add a keyword to the parser? (INITCAP is not a keyword, 
and it parses fine because it uses ordinary function syntax.)
* In the reference, remove VARCHAR2 (that type is Oracle-specific). Mention 
that the function is Oracle-only.

I'll need to do further testing. I'll mark if "fix in 1.18" so we don't forget.

> CHR support
> -----------
>
>                 Key: CALCITE-2510
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2510
>             Project: Calcite
>          Issue Type: Task
>          Components: core
>            Reporter: Sergey Tsvetkov
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.18.0
>
>
> Adding CHR() function support, available in Oracle & PostgreSql
> [https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions019.htm]
> [https://www.postgresql.org/docs/9.4/static/functions-string.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to