[
https://issues.apache.org/jira/browse/CALCITE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641412#comment-16641412
]
Julian Hyde commented on CALCITE-2326:
--------------------------------------
bq. I think that the more specific simplify method which can be directed how to
handle unknown values should be changed to be "internal-only public api" or
something like that.
In CALCITE-2604, I made {{simplify(RexNode)}} and {{simplifyUnknownAsFalse}}
public. There is a {{simplify(RexNode, RexUnknownAs)}} method that is public,
but most of the uses are internal.
bq. seems to me that simplifyNot is probably making some unneccessary
simplify() calls on every operand. should I file a separate jira for that?
[~kgyrtkirk], Yes, please log a separate JIRA.
[~vlsi], I've done most of the things you asked for. The internal methods pass
{{RexUnknownAs}} as a parameter; making it a field would be a design error,
because it is too easy to forget to pass it.
> Generalize p(x) IS TRUE/FALSE/UNKNOWN handling in RexSimplify
> -------------------------------------------------------------
>
> Key: CALCITE-2326
> URL: https://issues.apache.org/jira/browse/CALCITE-2326
> Project: Calcite
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
>
> Currently only IS TRUE is handle by the unknownAsFalse field variable.
> The main goal would be to extend the logic to also handle IS FALSE cases (and
> possibly IS UNKNOWN too)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
