[
https://issues.apache.org/jira/browse/CALCITE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642181#comment-16642181
]
Vladimir Sitnikov commented on CALCITE-2326:
--------------------------------------------
I've no strong feeling regarding method names, however I would prefer
{{simplify.simplify(e, RexUnknownAs.UNKNOWN)}} instead of current
{{simplify.simplifyUnknownAs(e, RexUnknownAs.UNKNOWN)}}.
current {{simplifyUnknownAs}} method enforces caller to repeat UnknownAs twice,
and static import for RexUnknownAs.TRUE/FALSE would make code extremely hard to
read.
So I would prefer {{simplify.simplify(e, RexUnknownAs.FALSE)}} much better
rather than {{simplify.simplifyUnknownAs(e, FALSE)}}
> Generalize p(x) IS TRUE/FALSE/UNKNOWN handling in RexSimplify
> -------------------------------------------------------------
>
> Key: CALCITE-2326
> URL: https://issues.apache.org/jira/browse/CALCITE-2326
> Project: Calcite
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
>
> Currently only IS TRUE is handle by the unknownAsFalse field variable.
> The main goal would be to extend the logic to also handle IS FALSE cases (and
> possibly IS UNKNOWN too)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
