[ 
https://issues.apache.org/jira/browse/CALCITE-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654658#comment-16654658
 ] 

KrishnaKant Agrawal commented on CALCITE-2625:
----------------------------------------------

Yeah, that flag It is being used only for Parsing validations as of now.

Will use that only, but this change required me to add a boolean parameter in 
SqlWindow.create() which lead me to make the change at one place in the 
Parser.jj file in calcite-core.

This discussion can be made during PR Review. Or if you have any comments about 
it right now, I would be helpful.

> ROW_NUMBER, RANK generating Invalid SQL
> ---------------------------------------
>
>                 Key: CALCITE-2625
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2625
>             Project: Calcite
>          Issue Type: Bug
>          Components: jdbc-adapter
>            Reporter: KrishnaKant Agrawal
>            Assignee: Julian Hyde
>            Priority: Major
>
> The SQL standard says:- 
> If <ntile function>, <lead or lag function>, <rank function type> or 
> ROW_NUMBER is specified, then: … The window framing clause of WDX shall not 
> be present.
> So, Calcite should not print the Window Frames when such functions are used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to