[ 
https://issues.apache.org/jira/browse/CALCITE-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723847#comment-16723847
 ] 

KrishnaKant Agrawal commented on CALCITE-2625:
----------------------------------------------

{quote} In SqlImplementor.Context.toSql(RexProgram program, RexOver rexOver), 
look at sqlAggregateFunction.allowsFraming() and wipe out the upper and lower 
bound if framing is not allowed.{quote}
This makes sense. Will update SqlImplementor.Context.toSql(RexProgram program, 
RexOver rexOver) to not pass Bounds to SqlWindow if 
sqlAggregateFunction.allowsFraming() is false

> ROW_NUMBER, RANK generating Invalid SQL
> ---------------------------------------
>
>                 Key: CALCITE-2625
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2625
>             Project: Calcite
>          Issue Type: Bug
>          Components: jdbc-adapter
>            Reporter: KrishnaKant Agrawal
>            Assignee: Julian Hyde
>            Priority: Major
>
> The SQL standard says:- 
> If <ntile function>, <lead or lag function>, <rank function type> or 
> ROW_NUMBER is specified, then: … The window framing clause of WDX shall not 
> be present.
> So, Calcite should not print the Window Frames when such functions are used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to