[
https://issues.apache.org/jira/browse/CALCITE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799272#comment-16799272
]
Haisheng Yuan commented on CALCITE-2944:
----------------------------------------
Yeah, the field and constructor using indicator should be marked deprecated
explicitly, by annotation. Tests should be there to guarantee its correctness,
though.
> Lack of test for Aggregate.indicator
> ------------------------------------
>
> Key: CALCITE-2944
> URL: https://issues.apache.org/jira/browse/CALCITE-2944
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Attachments: image-2019-03-21-18-19-58-933.png
>
>
> Although Aggregate.indicator is discouraged to use, but no test cases
> guarantee indicator can work correctly. I tried to set indicator to always
> false in Aggregate constructor, it passed all the tests.
> !image-2019-03-21-18-19-58-933.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
