[
https://issues.apache.org/jira/browse/CALCITE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800187#comment-16800187
]
Julian Hyde commented on CALCITE-2944:
--------------------------------------
Yes, let's remove it (it's been 2 years since we discouraged it, in
CALCITE-1069). I think we should keep the parameter in public API calls, but
throw {{UnsupportedOperationException}} or {{IllegalArgumentException}} if
anyone provides the value {{true}}. Also remove the field where possible.
As noted in CALCITE-1069, you can still use the {{GROUPING}} function to get
what you need.
> Lack of test for Aggregate.indicator
> ------------------------------------
>
> Key: CALCITE-2944
> URL: https://issues.apache.org/jira/browse/CALCITE-2944
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Attachments: image-2019-03-21-18-19-58-933.png
>
>
> Although Aggregate.indicator is discouraged to use, but no test cases
> guarantee indicator can work correctly. I tried to set indicator to always
> false in Aggregate constructor, it passed all the tests.
> !image-2019-03-21-18-19-58-933.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
