[ 
https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852065#comment-16852065
 ] 

Julian Hyde commented on CALCITE-2969:
--------------------------------------

There are a whole bunch of deprecation warnings. Generally we stop using APIs 
internally when they are deprecated. [~danny0405], Can you please fix these 
warnings before 1.20?

{noformat}core/src/main/java/org/apache/calcite/rel/logical/LogicalCorrelate.java:[29,30]
 org.apache.calcite.sql.SemiJoinType in org.apache.calcite.sql has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/core/Correlate.java:[30,30] 
org.apache.calcite.sql.SemiJoinType in org.apache.calcite.sql has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/mutable/MutableRels.java:[35,35] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdRowCount.java:[30,35] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSemiJoinRule.java:[22,35]
 org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/rules/JoinToCorrelateRule.java:[27,35]
 org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdNodeTypes.java:[29,35] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdCollation.java:[23,45] 
org.apache.calcite.adapter.enumerable.EnumerableSemiJoin in 
org.apache.calcite.adapter.enumerable has been deprecated 
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSemiJoin.java:[31,35]
 org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPopulationSize.java:[25,35]
 org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java:[26,35] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnUniqueness.java:[33,35]
 org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUtil.java:[28,35] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdSize.java:[29,35] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdDistinctRowCount.java:[27,35]
 org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/mutable/MutableRels.java:[366,24] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/mutable/MutableRels.java:[367,13] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/mutable/MutableRels.java:[367,34] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdRowCount.java:[191,29] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/tools/Programs.java:[89,26] 
ENUMERABLE_SEMI_JOIN_RULE in 
org.apache.calcite.adapter.enumerable.EnumerableRules has been deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdNodeTypes.java:[117,67] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdNodeTypes.java:[119,30] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdCollation.java:[159,49] 
org.apache.calcite.adapter.enumerable.EnumerableSemiJoin in 
org.apache.calcite.adapter.enumerable has been deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPopulationSize.java:[88,35]
 org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java:[209,45]
 org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnUniqueness.java:[316,35]
 org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUtil.java:[118,7] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdSize.java:[180,42] 
org.apache.calcite.rel.core.SemiJoin in org.apache.calcite.rel.core has been 
deprecated 
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoinRule.java:[93,16]
 
EnumerableMergeJoin(org.apache.calcite.plan.RelOptCluster,org.apache.calcite.plan.RelTraitSet,org.apache.calcite.rel.RelNode,org.apache.calcite.rel.RelNode,org.apache.calcite.rex.RexNode,org.apache.calcite.util.ImmutableIntList,org.apache.calcite.util.ImmutableIntList,java.util.Set<org.apache.calcite.rel.core.CorrelationId>,org.apache.calcite.rel.core.JoinRelType)
 in org.apache.calcite.adapter.enumerable.EnumerableMergeJoin has been 
deprecated{noformat}


> Improve design of join-like relational expressions
> --------------------------------------------------
>
>                 Key: CALCITE-2969
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2969
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.19.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Danny Chan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.20.0
>
>          Time Spent: 31h
>  Remaining Estimate: 0h
>
> The existing join-like (Join, SemiJoin, Correlate, etc.) logical and physical 
> relational expressions have a few design issues which make some parts of the 
> codebase complicated and difficult to understand.
> The goal of this ticket is to improve the design of the respective 
> expressions based on the discussion in the dev list (see thread [Join, 
> SemiJoin, 
> Correlate|https://mail-archives.apache.org/mod_mbox/calcite-dev/201903.mbox/%3C8EEA04A0-4A77-4283-BD20-B019E19AE126%40apache.org%3E]).
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to