[
https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851327#comment-16851327
]
Julian Hyde commented on CALCITE-2969:
--------------------------------------
+1 I think this change is ready to go in now (i.e. before 1.20). It is a
significant change (92 files, 900 lines added, 700 lines removed) and will rot
if we do not merge soon. [~danny0405] has put in a lot of work and we owe it to
him to approve or to tell him what it would take to fix it.
What do you think, [~michaelmior], [~zabetak], [~hyuan], [~rubenql]?
Review comment:
* I noticed that in many cases where {{isSemiJoin}} is called, we would want
the same behavior for ANTI_JOIN as for SEMI_JOIN. It's not surprising, because
we haven't really got anti-join working. It's something we could fix in a
follow-up case.
* EnumerableMergeJoin (still) extends EquiJoin. I guess that we will make it
extend (just) Join in CALCITE-3089.
What are the next steps?
* I think CALCITE-2857 and CALCITE-2968 would become 'wontfix'.
* Shall we do CALCITE-3089 next? I guess it would have to be in 1.21.
* It seems that we have covered CALCITE-3037 in this change, so we should mark
it 'duplicate' when we merge.
> Improve design of join-like relational expressions
> --------------------------------------------------
>
> Key: CALCITE-2969
> URL: https://issues.apache.org/jira/browse/CALCITE-2969
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.19.0
> Reporter: Stamatis Zampetakis
> Assignee: Danny Chan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 30h 10m
> Remaining Estimate: 0h
>
> The existing join-like (Join, SemiJoin, Correlate, etc.) logical and physical
> relational expressions have a few design issues which make some parts of the
> codebase complicated and difficult to understand.
> The goal of this ticket is to improve the design of the respective
> expressions based on the discussion in the dev list (see thread [Join,
> SemiJoin,
> Correlate|https://mail-archives.apache.org/mod_mbox/calcite-dev/201903.mbox/%3C8EEA04A0-4A77-4283-BD20-B019E19AE126%40apache.org%3E]).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
