[ 
https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915407#comment-16915407
 ] 

Danny Chan commented on CALCITE-3282:
-------------------------------------

The key point is that we don't want the SqlTypeNameSpec/SqlDataTypeSpec to have 
a mess of branches to handle kinds of sql dialects unparse logic. Let's keep 
them clean from sql dialects and do these "dialect" thing in SqlDialect itself.

> Make every SqlDialect unparse their own data type
> -------------------------------------------------
>
>                 Key: CALCITE-3282
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3282
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: feng huang
>            Priority: Minor
>
> Every database might have different type or same type but different type 
> name, therefore making every SqlDialect unparse their own data type is a 
> suitable way.
> For example, there is a sql “select cast(col as int) from table” change to 
> hive sql "select cast(col as integer) from table", but "integer" is not 
> allowed in hive.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to