[ 
https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918226#comment-16918226
 ] 

Jacky Woo commented on CALCITE-3282:
------------------------------------

Hi Danny, we realize your consideration.

But there is also a point that in addition to cast clause, there are other sql 
clauses containing data type, such as create table clause, which can not be 
handled in  SqlDialect#unparseCall method.

> Make every SqlDialect unparse their own data type
> -------------------------------------------------
>
>                 Key: CALCITE-3282
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3282
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: feng huang
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Every database might have different type or same type but different type 
> name, therefore making every SqlDialect unparse their own data type is a 
> suitable way.
> For example, there is a sql “select cast(col as int) from table” change to 
> hive sql "select cast(col as integer) from table", but "integer" is not 
> allowed in hive.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to