[
https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927865#comment-16927865
]
Julian Hyde commented on CALCITE-3329:
--------------------------------------
I'm worried about the call
{{getResource("/hyperic-sigar-1.6.4/sigar-bin/lib/")}}. Does this mean we are
relying on binaries having been installed? (And if so, will these commands fail
if people have not installed sigar?) Or is this resource coming from a .jar
file that needs to be on the class path?
There's a lot of redundancy between the testXxx methods, e.g. testSystemInfo
and testJavaInfo. The only difference is the table name and the number of
columns. Could you abstract the common code into a method that takes table name
and column count as arguments?
> Implement osquery for OS adapter
> --------------------------------
>
> Key: CALCITE-3329
> URL: https://issues.apache.org/jira/browse/CALCITE-3329
> Project: Calcite
> Issue Type: New Feature
> Reporter: Forward Xu
> Assignee: Forward Xu
> Priority: Major
> Labels: pull-request-available
> Attachments: 20160218233133330.png, 20160218233139164.png,
> image-2019-09-09-08-27-56-974.png, image-2019-09-09-08-33-41-411.png,
> sigar1.pdf, sigar2.pdf
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Implement osquery command for OS adapter, Achieve similar features of
> FaceBook's osquery. E.g:
> select * from os_version;
> select * from system_info;
> select * from mounts;
> select * from interface_addresses
> select * from memory_info;
> select * from interface_addresses;
> select * from cpu_info;
> select * from java_info;
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
