[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962014#comment-16962014
]
jin xing commented on CALCITE-2970:
-----------------------------------
[~xndai]
Thanks a lot for your kind help ~
Your commit is light weight and helpful for me
"""I understand we cannot just create EnumerableSort as there maybe other
conventions. But I think it's totally reasonable to just create a corresponding
physical sort when convention is known. When we know exactly the required
convention and collation trait, there's no reason to create yet another logical
node. """
It make much sense for me.
> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
> Key: CALCITE-2970
> URL: https://issues.apache.org/jira/browse/CALCITE-2970
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by
> making {{useAbstractConvertersForConversion}} return true,
> {{JDBCTest.testJoinManyWay}} will not complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
