[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968643#comment-16968643
]
Julian Hyde commented on CALCITE-2970:
--------------------------------------
If we added a {{Convention}} argument to {{sortLimit}} we pretty soon would add
it to many other {{RelBuilder}} methods. It's not a good step.
Maybe {{RelBuilder withConvention(Convention)}}, or {{RelBuilder
pushConvention(Convention)}} and {{RelBuilder popConvention()}}.
Even this would not address the needs of {{AbstractRelNode.copy}}, which is to
match all applicable traits.
> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
> Key: CALCITE-2970
> URL: https://issues.apache.org/jira/browse/CALCITE-2970
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by
> making {{useAbstractConvertersForConversion}} return true,
> {{JDBCTest.testJoinManyWay}} will not complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
