[
https://issues.apache.org/jira/browse/CALCITE-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992215#comment-16992215
]
Jin Xing commented on CALCITE-3549:
-----------------------------------
Thanks a lot for feedback ~ [~julianhyde]
Yes, it seems lots of Public APIs are changed, which is also my concern. I want
explain by two reasons as below:
# Public constructors of ViewTable ViewTableMacro MaterializedViewTable
Lattice MaterializationActor.Materialization are extended, by which we can
cache the lex config. There's no unified form for the caching and I can only
store lex config into different kinds of objects. For such public constructors,
I kept the original form and extended some new ones.
# Schemas#[parse, convert, analyzeView] didn't provide a param to pass in
Map<CalciteConnectionProperty, String> just as Schemas#prepare. I need to
extend to pass in the properties. Thankfully, these methods are mainly used for
Calcite internal, so I just modified the interface. The same reason for
MaterializationService#defineMaterialization and RelOptView#ViewExpander
> Lex config for view expanding is not supported
> ----------------------------------------------
>
> Key: CALCITE-3549
> URL: https://issues.apache.org/jira/browse/CALCITE-3549
> Project: Calcite
> Issue Type: Improvement
> Reporter: Jin Xing
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> UT as below:
> {code:java}
> // JdbcTest.java
> @Test public void testDEV() {
> modelWithView("select * from EMPLOYEES where deptno = 10", null)
> .with(Lex.JAVA)
> .query("select * from adhoc.V order by name desc")
> .returns("");
> }
> {code}
> Failed with
> {code:java}
> org.apache.calcite.sql.validate.SqlValidatorException: Column 'DEPTNO' not
> found in any table; did you mean 'deptno'?
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
