[
https://issues.apache.org/jira/browse/CALCITE-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993487#comment-16993487
]
Ruben Q L commented on CALCITE-3576:
------------------------------------
I have looked at the generated code, both the original one (with hashJoin) and
the new one (with my change CALCITE-3535, with nestedLoopJoin); and _I think_
that the original one is already wrong, and maybe it was just working by chance?
I can see that the hashJoin version performs a Comparator.toString() operation
(which does not make much sense, but at least does not throw any exception);
whereas the nestedLoopJoin version tries to cast a Comparator into String
(which causes the ClassCastException described by [~hyuan] above). I think that
the issue is not related to hashJoin or nestedLoopJoin, or the changes
introduced by this ticket or CALCITE-3535, but rather why this
Comparator-to-String operation was generated in the first place, which I
believe seems to be an error. Maybe there is an old underlying problem
somewhere, which was "hidden" so far.
> Remove Enumerable convention check in FilterIntoJoinRule
> --------------------------------------------------------
>
> Key: CALCITE-3576
> URL: https://issues.apache.org/jira/browse/CALCITE-3576
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
