[
https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029002#comment-17029002
]
Chunwei Lei commented on CALCITE-3192:
--------------------------------------
Thanks for your reply, [~kgyrtkirk].
I am sorry that I might not provide the case clearly. Without your patch,
{code:java}
1) (1<a) or ((a<3 and b=2)){code}
will be simplified to
{code:java}
2) 1<a or b=2{code}
, which is wrong. Because if a=null and b=2, 1) returns null, but 2) returns
true. Is this the issue you want to fix?
> Simplification may weaken OR conditions containing inequalities
> ---------------------------------------------------------------
>
> Key: CALCITE-3192
> URL: https://issues.apache.org/jira/browse/CALCITE-3192
> Project: Calcite
> Issue Type: Bug
> Reporter: Jess Balint
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.21.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> RexSimplify is transforming
> * {{OR(AND(>(999, $8), =($2, 'Franklin')), <(100, $8))}}
> * to {{OR(=($2, 'Franklin'), <(100, $8))}}
> the predicates are accumulated in {{simplifyOrTerms()}} but not discarded
> when iterating the second time
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
