[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045210#comment-17045210
]
Vladimir Sitnikov commented on CALCITE-3769:
--------------------------------------------
[~eolivelli] mentioned that this change [breaks
HerdDB|https://lists.apache.org/thread.html/r5c3395a36277a58546c605fed8d38e6702ec7ae2ed1abf02dc9078e2%40%3Cdev.calcite.apache.org%3E]
as well.
{quote}You are accusing reviewers of having double standards.{quote}
[~julianhyde], please don't get me wrong, but what I said was "PR#1790 did
multiple modifications to the **expected** test output ==> it is very likely
the change is not backward-compatible".
It was not like "I am receiving bad reviews". It was like "Hey, Julian and
Danny, it looks like the PR is breaking backward compatibility. Do you mind to
double-check and avoid committing that in a minor version?"
Of course, we all know that Calcite's minor versions routinely include
backward-incompatible changes like "alter join class hierarchy", "replace
Project with LogicalProject", and so on. However, it does look strange when
user-visible backward-incompatible changes are introduced with absolutely
missing upgrade guide.
> Deprecate TableScanRule
> -----------------------
>
> Key: CALCITE-3769
> URL: https://issues.apache.org/jira/browse/CALCITE-3769
> Project: Calcite
> Issue Type: Wish
> Components: core
> Affects Versions: 1.21.0
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The TableScanRule is the only planner rule that for a logical node(e.g. the
> table scan), its function is to pass along the cluster object and invoke the
> RelOptTable#toRel which is very trivial because it supplies only a simple
> ToRelContext that does not support expanding view/passing table hints.
> For rels that come from the sql-to-rel conversion, there is already a table
> conversion logic[1]. This code gives a more powerful ToRelContext that has
> the complete functionality.
> The only reason that I saw the meaning of existing TableScanRule is for the
> TableScan that comes from the RelBuilder#scan.
> So I would suggest to deprecate the TableScanRule, instead, we support
> translating the table directly in RelBuilder#scan,
> -We also add a new interface RelBuilder#scan(Iterable<String> tableNames,
> ToRelContext context), so that user can pass in a more powerful ToRelContext
> explicitly.- User can customize a TableScanFactory in the RelBuilder to do
> this.
> [1]
> https://github.com/apache/calcite/blob/d6fa25cd11625ad7b4b74dafbd0211c701b38d49/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L3498
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
