[
https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057621#comment-17057621
]
Liya Fan commented on CALCITE-3851:
-----------------------------------
[~Chunwei Lei][~hyuan] Thanks for your feedback.
[~Chunwei Lei] I agree with you that the {{setImportance}} API is confusing, as
the importance value is useless and misleading. Maybe we need to replace it
with a new API.
[~hyuan] the idea behind the SubstitutionRule interface is innovative. I am a
little concerned that it does not solve all the problems. For some scenarios,
we have to dynamically determine if the new plan will replace the old one
forcibly. For such scenarios, calling the {{setImportance}} API should be the
only choice?
> Replace the node importance map with a set for pruned nodes
> -----------------------------------------------------------
>
> Key: CALCITE-3851
> URL: https://issues.apache.org/jira/browse/CALCITE-3851
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Liya Fan
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, volcano planner stores rel node importances with a map. In fact,
> the value of the map can only be 0.
> So there is no need to store the values, and we replace the map with a set to
> store nodes whose importances are 0.
> This makes the code logic clearer, and avoids instability caused by comparing
> floating point values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
