[
https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058112#comment-17058112
]
Julian Hyde commented on CALCITE-3851:
--------------------------------------
'set importance = 0' has always been a hack. Now we are steadily removing
importance, it is time to break this behavior out as a feature, and explain the
concept without talking about 'importance'. Create new APIs that don't use the
word 'importance', and deprecate the old ones. The concept should be fully
specified (probably in javadoc somewhere), in terms of what should and should
not happen in various cases. And there should be tests for it.
> Replace the node importance map with a set for pruned nodes
> -----------------------------------------------------------
>
> Key: CALCITE-3851
> URL: https://issues.apache.org/jira/browse/CALCITE-3851
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Liya Fan
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, volcano planner stores rel node importances with a map. In fact,
> the value of the map can only be 0.
> So there is no need to store the values, and we replace the map with a set to
> store nodes whose importances are 0.
> This makes the code logic clearer, and avoids instability caused by comparing
> floating point values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
