[ 
https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067299#comment-17067299
 ] 

Danny Chen commented on CALCITE-3871:
-------------------------------------

Currently, we only use this annotations in module calcite-core and 
calcite-linq4j, which is reasonable because these two modules contain the core 
APIs for Calcite. That is why i add the class in calcite-linq4j, so that any 
module that have calcite-core or calcite-linq4j as dependency would also see 
this class.

And yes, all the modules have a calcite-core dependency, so this is not a 
problem.

> Remove dependency of org.apiguardian:apiguardian-api
> ----------------------------------------------------
>
>                 Key: CALCITE-3871
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3871
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core, linq4j
>    Affects Versions: 1.22.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.23.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The org.apiguardian:apiguardian-api is introduced in CALCITE-3652 in order to 
> mark the new introduced API status.
> Remove the dependency and copy the class into Calcite because the 
> org.apiguardian:apiguardian-api jar has only a single API.java class and it 
> is not necessary to add a dependency for that(All the downstream projects 
> that have calcite-core as a dependency would see this jar which is annoying).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to