[
https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067913#comment-17067913
]
Julian Hyde commented on CALCITE-3871:
--------------------------------------
I disagree with this change. Using a publicly accepted set of annotations is
far preferable to having our own copy.
We already do this for javax.annotation.
The argument that we only use it in two places is not valid. We should be using
it in more places. As a project we have not done a great job of calling out our
public API.
Danny, you forged ahead and did not answer [~zabetak]'s objections. Why?
> Remove dependency of org.apiguardian:apiguardian-api
> ----------------------------------------------------
>
> Key: CALCITE-3871
> URL: https://issues.apache.org/jira/browse/CALCITE-3871
> Project: Calcite
> Issue Type: Improvement
> Components: core, linq4j
> Affects Versions: 1.22.0
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.23.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The org.apiguardian:apiguardian-api is introduced in CALCITE-3652 in order to
> mark the new introduced API status.
> Remove the dependency and copy the class into Calcite because the
> org.apiguardian:apiguardian-api jar has only a single API.java class and it
> is not necessary to add a dependency for that(All the downstream projects
> that have calcite-core as a dependency would see this jar which is annoying).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
