[ 
https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073348#comment-17073348
 ] 

neoremind commented on CALCITE-3891:
------------------------------------

[~hyuan] I am curious what tool did you use to generate the graph? I've made a 
similar check by using flame graph, see attachment in 
https://issues.apache.org/jira/browse/CALCITE-3873 . Correct me if I am wrong, 
the "flat roof" might be what to be paid more attention, the sampling I made 
seems does not catch RelTraitSet#matches.

> Remove use of Pair.zip in RelTraitSet.satisfies
> -----------------------------------------------
>
>                 Key: CALCITE-3891
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3891
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Haisheng Yuan
>            Assignee: Chunwei Lei
>            Priority: Major
>         Attachments: image-2020-04-01-19-05-58-306.png
>
>
> It accounts too much time of the method, even this is a tiny portion overall.
>  !image-2020-04-01-19-05-58-306.png! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to