[
https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074178#comment-17074178
]
Julian Hyde commented on CALCITE-3891:
--------------------------------------
I wrote that code, but since it shows up in profiling, feel free to change it.
I suspect a 'for (int i = 0; i < traits.length; i++)' loop would be just fine.
Regarding {{Flat2List}}. Someone could try overriding
{{Iterable.forEach(Consumer)}} for {{Flat2List}} and using it rather than a for
loop. It might be better than {{Flat2List.iterator}}.
> Remove use of Pair.zip in RelTraitSet.satisfies
> -----------------------------------------------
>
> Key: CALCITE-3891
> URL: https://issues.apache.org/jira/browse/CALCITE-3891
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Assignee: Chunwei Lei
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2020-04-01-19-05-58-306.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> It accounts too much time of the method, even this is a tiny portion overall.
> !image-2020-04-01-19-05-58-306.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
