[
https://issues.apache.org/jira/browse/CALCITE-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087412#comment-17087412
]
Danny Chen commented on CALCITE-3931:
-------------------------------------
It is hard to write a test case, i have tested and validated locally with my
sql parser extension.
{quote}it doesn't seem right that you have LOOKAHEAD only AFTER a '|'
separator{quote}
If we want to solve the conflicts between the multiple branches of just
SqlCreate, LOOKAHEAD after '|' separator is enough. The first branch would have
LOOKAHEAD(1) but it still works.
> Add LOOKAHEAD(2) for methods defined in createStatementParserMethods
> --------------------------------------------------------------------
>
> Key: CALCITE-3931
> URL: https://issues.apache.org/jira/browse/CALCITE-3931
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.22.0
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.23.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The default LOOKAHEAD is 1 which is very probably to conflict, especially for
> custom parse block like SqlCreate.
>
> Sets the LOOKAHEAD(2) to reduce conflict.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
