[ 
https://issues.apache.org/jira/browse/CALCITE-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087978#comment-17087978
 ] 

Julian Hyde commented on CALCITE-3931:
--------------------------------------

I don't understand why you didn't do the following. It's more similar to other 
places in the grammar, and it applies the lookahead even in the first branch:
{code}
    (
<#-- additional literal parser methods are included here -->
<#list parser.createStatementParserMethods as method>
        LOOKAHEAD(2) create = ${method}(s, replace)
        <#sep>|</#sep>
</#list>
    )
{code}

> Add LOOKAHEAD(2) for methods defined in createStatementParserMethods
> --------------------------------------------------------------------
>
>                 Key: CALCITE-3931
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3931
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.22.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.23.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The default LOOKAHEAD is 1 which is very probably to conflict, especially for 
> custom parse block like SqlCreate.
>     
> Sets the LOOKAHEAD(2) to reduce conflict.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to