[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099395#comment-17099395
]
Xiening Dai commented on CALCITE-2970:
--------------------------------------
{quote}Out of curiosity can you explain at which point you want to create and
pass the sub-classed RelBuilder?
{quote}
Suppose we have a system X that supports user define join. It might want to
extend the RelBuilder to have a a method like XRelBuilder#userDefinedJoin(),
which leverages the base class functions and creates UDJ operator. Note that
this capability is independent from RelNode conventions. XRelBuilder could
create logical or physical UDJ node.
I don't want people feel I try to force one way over the other. But just to
present the pros/cons and the rationale behind it. I still appreciate your
comments. Please keep doing that in the future. Thanks! :)
> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
> Key: CALCITE-2970
> URL: https://issues.apache.org/jira/browse/CALCITE-2970
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 18h 20m
> Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by
> making {{useAbstractConvertersForConversion}} return true,
> {{JDBCTest.testJoinManyWay}} will not complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
