[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099388#comment-17099388
]
Stamatis Zampetakis commented on CALCITE-2970:
----------------------------------------------
Out of curiosity can you explain at which point you want to create and pass the
sub-classed {{RelBuilder}}?
Looking into the implementation of \{{call.builder()}} I get the impression
that we may still create a new {{RelBuilder}} in every call. Regarding object
creation, I think it boils down to what {{RelBuilderFactory}} does inside the
{{create}} method.
The benefit that I see is simpler and more intuitive APIs but this is
subjective :) As I said previously, you convinced the rest of the people so you
don't necessarily have to convince me. Since I was involved in the discussion I
am just giving my opinion.
> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
> Key: CALCITE-2970
> URL: https://issues.apache.org/jira/browse/CALCITE-2970
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 18h 20m
> Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by
> making {{useAbstractConvertersForConversion}} return true,
> {{JDBCTest.testJoinManyWay}} will not complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
