[
https://issues.apache.org/jira/browse/CALCITE-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108641#comment-17108641
]
Julian Hyde commented on CALCITE-3946:
--------------------------------------
Reviewing the PR:
* I see you made "babel" depend on "server". I'm not sure we want that coupling
(bringing in server's RPC capability, or over-coupling third-party DDL syntax
to Calcite's DDL syntax). I sent an email to dev@ to discuss. I have also
pushed a branch with a commit that solves the problem in another way - by
copy-pasting some classes. See
https://github.com/julianhyde/calcite/tree/3946-create-table. Let's see what
consensus emerges on dev@ before moving forward.
* "In teradata mode" - it would be good to be more specific how to set that
mode. Reference conformance or dialect or whatever is the appropriate switch.
* A couple of lines in .ftl are over long. Chop them down to 80 to 100 chars.
Overall, looks good, nice work. With these fixes, when commits re-open after
1.23 we should be able to merge soon after.
> Add parser support for MULTISET/SET and VOLATILE modifiers in CREATE TABLE
> statements
> -------------------------------------------------------------------------------------
>
> Key: CALCITE-3946
> URL: https://issues.apache.org/jira/browse/CALCITE-3946
> Project: Calcite
> Issue Type: Improvement
> Components: babel
> Affects Versions: 1.22.0
> Reporter: Drew Schmitt
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add support to Calcite's Babel parser for {{MULTISET}}/{{SET}} and
> {{VOLATILE}} modifiers in {{CREATE TABLE}} statements.
> The syntax for these statements is:
> {code:sql}
> CREATE TABLE [SET|MULTISET] [VOLATILE] <table_name>
> [IF NOT EXISTS] (<column_name> <data_type>, ...);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
