[ 
https://issues.apache.org/jira/browse/CALCITE-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108675#comment-17108675
 ] 

Drew Schmitt commented on CALCITE-3946:
---------------------------------------

Thanks for the feedback!
- I'm interested to see what the community decides on regarding babel vs. 
server dependency. I agree that intuitively babel should take a dependency on 
server. I've preemptively updated my PR to incorporate your changes in 
3946-create-table. I can change to some other model if that's the consensus.

- Teradata vs. ANSI mode is controlled by the client. The mode changes the 
behavior of a given query (e.g. defaulting to using MULTISET vs. SET when 
unspecified). However, AFAIK it shouldn't impact the parsing or validation. As 
such, we shouldn't need to provide a way to switch between modes in Calcite. I 
can remove the comment altogether if it makes things more confusing.

- I've line-wrapped the long lines.

> Add parser support for MULTISET/SET and VOLATILE modifiers in CREATE TABLE 
> statements
> -------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3946
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3946
>             Project: Calcite
>          Issue Type: Improvement
>          Components: babel
>    Affects Versions: 1.22.0
>            Reporter: Drew Schmitt
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Add support to Calcite's Babel parser for {{MULTISET}}/{{SET}} and 
> {{VOLATILE}} modifiers in {{CREATE TABLE}} statements.
> The syntax for these statements is:
> {code:sql}
>  CREATE TABLE [SET|MULTISET] [VOLATILE] <table_name>
>    [IF NOT EXISTS] (<column_name> <data_type>, ...);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to