[
https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136139#comment-17136139
]
Julian Hyde commented on CALCITE-4027:
--------------------------------------
Reviewing the PR:
* Isn't there logic elsewhere to derive the name of the ref file? Re-use it.
* Don't put 'core' in the property name. It could be used in other modules.
* Define your property in CalciteSystemProperty, and use standard methods for
parsing boolean properties.
> Add -Doverwrite option to SqlToRelTestBase
> ------------------------------------------
>
> Key: CALCITE-4027
> URL: https://issues.apache.org/jira/browse/CALCITE-4027
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Attachments: image-2020-06-14-09-28-05-925.png
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> So that by setting overwrite=true, the expected xml file will be overwritten
> by actual output file automatically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
