[ 
https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153860#comment-17153860
 ] 

Julian Hyde commented on CALCITE-4027:
--------------------------------------

Reviewing the PR again:
* Don't swallow the IOException. Re-throw.
* I repeat, use CalciteSystemProperty and parsing methods
* I repeat, re-use logic to derive the name of the ref file.

> Add -Doverwrite option to SqlToRelTestBase
> ------------------------------------------
>
>                 Key: CALCITE-4027
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4027
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2020-06-14-09-28-05-925.png
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> So that by setting overwrite=true, the expected xml file will be overwritten 
> by actual output file automatically.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to