[
https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139028#comment-17139028
]
Danny Chen commented on CALCITE-4056:
-------------------------------------
Why would you think 10% reduction for memory is not significant. I'm not sure
100% i solved the problem, but at lease i made the thing better and move
forward there.
And what this patch fixed ?
In total, the PR has no one review comment and got merged for no reason, what's
wrong there ~
And CALCITE-3786 is still in progress, we at lease we should move on when after
we reached an agreement.
I have to say that this commit makes me so angry, please learn to respect.
> Remove Digest from RelNode and RexNode
> --------------------------------------
>
> Key: CALCITE-4056
> URL: https://issues.apache.org/jira/browse/CALCITE-4056
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Fix For: 1.24.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The digest is used everywhere (RelNode, RexNode, DataType), causing OOM
> easily for large queries or with complex expressions. Datatype is cached in
> global interner and can be reused. Unlike RelNode, RexNode is not stored in
> MEMO as a GROUP, causing it can't be shared. This makes Calcite can't scale
> for large queries, e.g. CALCITE-3784.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
