[
https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139033#comment-17139033
]
Danny Chen commented on CALCITE-4056:
-------------------------------------
I think no one comment in the Laurent's fix matched what you fixed, except the
array digest item which i think is not necessary.
And i have to say, the new code is a mess. I would give -1 for the code style,
but before a review there, let's make agreement if the Digest is deserve to be
removed.
> Remove Digest from RelNode and RexNode
> --------------------------------------
>
> Key: CALCITE-4056
> URL: https://issues.apache.org/jira/browse/CALCITE-4056
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Fix For: 1.24.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The digest is used everywhere (RelNode, RexNode, DataType), causing OOM
> easily for large queries or with complex expressions. Datatype is cached in
> global interner and can be reused. Unlike RelNode, RexNode is not stored in
> MEMO as a GROUP, causing it can't be shared. This makes Calcite can't scale
> for large queries, e.g. CALCITE-3784.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
