[ 
https://issues.apache.org/jira/browse/CALCITE-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166484#comment-17166484
 ] 

Michael Mior commented on CALCITE-4128:
---------------------------------------

LGTM, and I know a related discussion came up elsewhere, but I wonder if it 
would make sense to also avoid making the demo CSV adapter dependent on the 
file adapter. It would have significantly less functionality and would result 
in some code duplication, but could also serve as a bare bones adapter example. 
This would be a breaking change since people using the CSV adapter may have to 
switch to the file adapter to get the same functionality.

> Remove dependency of File adapter on Demo CSV adapter
> -----------------------------------------------------
>
>                 Key: CALCITE-4128
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4128
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.25.0
>
>
> Remove dependency of File adapter on Demo CSV adapter.
> The dependency should be in the other direction. We want the File adapter to 
> have lots of capabilities, and the Demo CSV adapter to be easy to understand.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to