[
https://issues.apache.org/jira/browse/CALCITE-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183601#comment-17183601
]
Julian Hyde commented on CALCITE-3782:
--------------------------------------
[~hailong wang], Nice work. I have a couple of comments. No need to change
anything.
Why special-case {{byteString.size() == 0}} in {{binaryOperator}}? Zero-length
ByteStrings are not special. But after reading that code, now people think that
they are.
If your goal was to prevent duplicate ByteString values, you could do an
equality check, and it would help other cases besides the corner case.
I see you added the resource to the end of CalciteResource.properties. You may
think that is the polite thing to do. But actually it isn't. It will tend to
conflict with changes from other people who think they are being polite. And it
indicates that you didn't seriously think about the best place to put this
resource in the file. As a rule of thumb, never add stuff to the end of a file.
> Bitwise operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
> ------------------------------------------------------------------------------
>
> Key: CALCITE-3782
> URL: https://issues.apache.org/jira/browse/CALCITE-3782
> Project: Calcite
> Issue Type: Sub-task
> Components: core
> Affects Versions: 1.22.0
> Reporter: hailong wang
> Assignee: hailong wang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.26.0
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> According to the discussion link CALCITE-3732 , We should make bitwise
> operators work on all integer types, BINARY and VARBINARY. So Bit_And, Bit_OR
> and Bit_XOR agg operator should also support BINARY and VARBINARY.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
