[ 
https://issues.apache.org/jira/browse/CALCITE-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188258#comment-17188258
 ] 

Vladimir Sitnikov commented on CALCITE-3782:
--------------------------------------------

[~julianhyde], I agree byteString.size() == 0 looks like a bug (e.g. it would 
produce wrong results for bitand(empty, non-empty)). It looks like an 
optimization, however, I'm not sure.

Regarding CalciteResource.properties, it looks we could reduce conflicts on the 
resources file if we add merge=union to gitattributes.

> Bitwise operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
> ------------------------------------------------------------------------------
>
>                 Key: CALCITE-3782
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3782
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.22.0
>            Reporter: hailong wang
>            Assignee: hailong wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.26.0
>
>          Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> According to the discussion  link CALCITE-3732 , We should make bitwise 
> operators work on all integer types, BINARY and VARBINARY. So Bit_And, Bit_OR 
> and Bit_XOR agg operator should also support BINARY and VARBINARY.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to