[
https://issues.apache.org/jira/browse/CALCITE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350864#comment-17350864
]
Ruben Q L commented on CALCITE-4608:
------------------------------------
[~amrishlal] commit messages (and their corresponding Jiras) should not begin
with "Fix ...". Normally they should describe the issue. In this case, this
patch does not fix the NPE (which was already handled via CALCITE-4199), thus
may I suggest in this case something along the lines
"SqlLiteral#createApproxNumeric does not correctly set scale and precision".
What do you think?
Also, as [~julianhyde] said, could you please add a SQL test?
> Fix NullPointerException in SqlNumericLiteral.isInteger()
> ---------------------------------------------------------
>
> Key: CALCITE-4608
> URL: https://issues.apache.org/jira/browse/CALCITE-4608
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 1.26.0
> Reporter: Amrish Lal
> Assignee: Ruben Q L
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.27.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {{A NullPointerException is thrown in SqlNumericLiteral.isInteger(), due to
> "this.scale" being null. This can be reproduced by compiling SQL statement
> "SELECT * FROM testTable WHERE floatColumn > 1.7976931348623157E308".}}
> {{A null check was added through CALCITE-4199 to fix the
> NullPointerException; however, the root cause is that scale and precision are
> not being properly set in }}{{SqlLiteral.createApproxNumeric function which
> is called to handle }}{{APPROX_NUMERIC_LITERAL token.}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
