[
https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397723#comment-17397723
]
Josh Elser commented on CALCITE-4727:
-------------------------------------
{quote}That said [~elserj] per your comment the code snippet does say
{{RpcMetadataResponse}}, i.e., includes the term `response` for the JSON
messages, and per
[here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678]
(as mentioned in the issue description) it seems like the RpcMetadata is
somewhat of an atypical
[miscellaneous|https://calcite.apache.org/avatica/docs/json_reference.html#miscellaneous]
type.
{quote}
The comment you're referring to here is simply saying that the class name is
"incorrectly" named as a "Response", not meant to imply that it requires a
"response" attribute.
Given your (excellent) explanation, it sounds to me like the JSON serialization
path is unexpectedly requiring the "response" attribute. In terms of the code
itself, Avatica is doing nothing with an "response" attribute on that message.
I know that we don't have a `response` attribute on the protobuf side.
Do you happen to have an encapsulated example I could run? (if not, I'll see if
I can gin something up).
> Possible incorrect RpcMetadata JSON reference
> ---------------------------------------------
>
> Key: CALCITE-4727
> URL: https://issues.apache.org/jira/browse/CALCITE-4727
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: John Bodley
> Priority: Trivial
>
> Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the
> RpMetadata JSON reference is missing the required `response` field. As
> discussed in the issue and per
> [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678],
> though this isn't an actual response is does seem to expect a response type
> signature.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
