[ 
https://issues.apache.org/jira/browse/CALCITE-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397734#comment-17397734
 ] 

Julian Hyde commented on CALCITE-4724:
--------------------------------------

Thanks. In CALCITE-3191 (which is very similar to this), 3 test methods were 
added. Can you add ClickHouse to each of those tests.

> ClickHouseSqlDialect `supportsAliasedValues` should return false.
> -----------------------------------------------------------------
>
>                 Key: CALCITE-4724
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4724
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.27.0
>            Reporter: Enze Liu
>            Priority: Minor
>              Labels: pull-request-available, pull-requests-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We use ClickHouseSqlDialect to do some sql optimize. 
> for sql `select 1`, in the process of sqlNode -> relNode -> sqlNode, the sql 
> string will be transformed to 
> {code:java}
> SELECT *
> FROM (VALUES (1)) AS `t` (`EXPR$0`)
> {code}
> Since clickhouse is not support AliasedValues, all we need to do is to extend 
> ClickHouseSqlDialect and make `supportsAliasedValues` return false. 
> Maybe this kind of behavior can integrated into core? 
> If needed, the pull request is ready.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to