[
https://issues.apache.org/jira/browse/CALCITE-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397858#comment-17397858
]
Julian Hyde commented on CALCITE-4724:
--------------------------------------
I was mistaken. {{testValues}} and {{testValuesEmpty}} are sufficient.
I think that "In JDBC adapter for ClickHouse, implement Values by generating
SELECT without FROM" is a better subject. I wrote the {{supportsAliasedValues}}
method and even I can barely figure out what the name means.
I added a commit, reorganizing the tests a little. Please review my changes in
[julianhyde/4724-clickhouse-values|https://github.com/julianhyde/calcite/tree/4724-clickhouse-values].
> ClickHouseSqlDialect `supportsAliasedValues` should return false.
> -----------------------------------------------------------------
>
> Key: CALCITE-4724
> URL: https://issues.apache.org/jira/browse/CALCITE-4724
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.27.0
> Reporter: Enze Liu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We use ClickHouseSqlDialect to do some sql optimize.
> for sql `select 1`, in the process of sqlNode -> relNode -> sqlNode, the sql
> string will be transformed to
> {code:java}
> SELECT *
> FROM (VALUES (1)) AS `t` (`EXPR$0`)
> {code}
> Since clickhouse is not support AliasedValues, all we need to do is to extend
> ClickHouseSqlDialect and make `supportsAliasedValues` return false.
> Maybe this kind of behavior can integrated into core?
> If needed, the pull request is ready.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
