[ 
https://issues.apache.org/jira/browse/CALCITE-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452603#comment-17452603
 ] 

Aleksey Plekhanov commented on CALCITE-4915:
--------------------------------------------

[~julianhyde],
{quote}Would it be better to make the method non-static?
{quote}
As for me, non-static method looks nicer. But I think we should also change 
{{expandCommonColumn}} to non-static to match other "expand*" methods semantic, 
WDYT?
Ok, I will file tickets about three-way JOINS and about issues with system 
column filtering tomorrow. 
What about {{ORDER BY}} issue? Currently queries like:
{noformat}
SELECT name FROM emp JOIN dept USING (deptno) ORDER BY deptno{noformat}
Still fail for JOINs with USING and for NATURAL JOINs. 

Should I fix this with the current ticket (I've just found it and don't have a 
fix currently), or it's better to fix it with a separate ticket?

> Query with unqualified common column and NATURAL JOIN fails
> -----------------------------------------------------------
>
>                 Key: CALCITE-4915
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4915
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Aleksey Plekhanov
>            Assignee: Aleksey Plekhanov
>            Priority: Major
>              Labels: pull-request-available
>
> Query with unqualified common column and NATURAL JOIN:
> {noformat}
> SELECT deptno FROM emp NATURAL JOIN dept{noformat}
> Fails with "Column 'DEPTNO' is ambiguous" error.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to