[
https://issues.apache.org/jira/browse/CALCITE-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452995#comment-17452995
]
Aleksey Plekhanov commented on CALCITE-4915:
--------------------------------------------
[~julianhyde],
I've filed new tickets: CALCITE-4921, CALCITE-4922, CALCITE-4923 for NATURAL
JOIN problems.
In the patch I've changed the method to non-static, also removed one
{{SqlToRelConverterTest,}} and added test to {{{}join.iq{}}}.
Can you please have a look again?
{quote}It sounds logical, but there is a CheckerFramework check that will
complain if you make a private method non-static that could be static. So don't
do it.
{quote}
Actually, these methods accept {{validator}} as parameters, so they look better
when they are non-static. I've prepared an alternative pull request with this
change to show what I mean and looks like CheckerFramework is happy. Here is
the commit where it changed
[https://github.com/apache/calcite/pull/2631/commits/de32c87efeae29f121f290a11f88031c2c652aa6]
> Query with unqualified common column and NATURAL JOIN fails
> -----------------------------------------------------------
>
> Key: CALCITE-4915
> URL: https://issues.apache.org/jira/browse/CALCITE-4915
> Project: Calcite
> Issue Type: Bug
> Reporter: Aleksey Plekhanov
> Assignee: Aleksey Plekhanov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Query with unqualified common column and NATURAL JOIN:
> {noformat}
> SELECT deptno FROM emp NATURAL JOIN dept{noformat}
> Fails with "Column 'DEPTNO' is ambiguous" error.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
