[
https://issues.apache.org/jira/browse/CALCITE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571106#comment-17571106
]
Julian Hyde commented on CALCITE-5217:
--------------------------------------
The PR has a massive list of commits. You should re-open it, then rebase it so
that it is just one commit. (We generally ask contributors not to rebase or
squash PRs but this is an exception.)
I imagine that the build fails. I saw some code changes that will break
checkstyle, probably. Please post here when your PR is passing the build, and
want us to review again.
In your unit test, can you test a few other dialects, not just Firebolt? If
possible, find an existing unit test that you can generalize. Having a test for
each feature x dialect combination doesn't scale.
> Implement unparseSqlIntervalLiteral in the Firebolt dialect
> -----------------------------------------------------------
>
> Key: CALCITE-5217
> URL: https://issues.apache.org/jira/browse/CALCITE-5217
> Project: Calcite
> Issue Type: Bug
> Reporter: Aymeric Dispa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The syntax used by Firebolt for the operator INTERVAL does not match with the
> query generated. To fix it, the method unparseSqlIntervalLiteral must be
> implemented in the dialect.
> What we get with the current dialect:
> {code:java}
> <date_column> + INTERVAL '1' DAY {code}
>
> Format supported by Firebolt
> {code:java}
> <date_column> + INTERVAL '1 DAY' {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
