[
https://issues.apache.org/jira/browse/CALCITE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571113#comment-17571113
]
Julian Hyde commented on CALCITE-5217:
--------------------------------------
Ah, I see.
Further comments:
* Blank line needed after close brace.
* It's strange that you call {{print}} several times. The base method calls
{{literal}} just once, with a concatenated string.
* You should probably test with a few more examples, e.g. negative intervals,
and intervals such as day:hour:minute. Is there a straightforward way to
generalize {{testLiteral}} for other dialects?
> Implement unparseSqlIntervalLiteral in the Firebolt dialect
> -----------------------------------------------------------
>
> Key: CALCITE-5217
> URL: https://issues.apache.org/jira/browse/CALCITE-5217
> Project: Calcite
> Issue Type: Bug
> Reporter: Aymeric Dispa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The syntax used by Firebolt for the operator INTERVAL does not match with the
> query generated. To fix it, the method unparseSqlIntervalLiteral must be
> implemented in the dialect.
> What we get with the current dialect:
> {code:java}
> <date_column> + INTERVAL '1' DAY {code}
>
> Format supported by Firebolt
> {code:java}
> <date_column> + INTERVAL '1 DAY' {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
