[
https://issues.apache.org/jira/browse/CALCITE-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601701#comment-17601701
]
Bertil Chapuis commented on CALCITE-5262:
-----------------------------------------
I based a lot of my tests on the exemples provided in the H2GIS documentation.
If this is ok, I think the PR is ready to be merged.
The following comments may be addressed in separate issues:
* I added many ST_ functions which are not related to the original issue in
this PR. They are low hanging fruits in the sense that their implementation
matches with JTS features. However, the tests do not cover all the corner cases
and small issues will probably arise once they are used more extensively (NPE,
etc.). One approach may be to wait for bug reports. Another approach may be to
find a way to spot most of them before merging. What do you prefer?
* Postgis and H2GIS sometimes seems to differ in subtle ways. In some cases, I
even wanted to implement the functions slightly differently. Should we keep the
"compatibility" column in the documentation? Personally, I would prefer to
remove this column and to describe the actual behavior implemented in Calcite.
H2GIS and Postgis should remain in the acknowlegement.
> Add functions to support WKB (well-known binary) and GeoJSON
> ------------------------------------------------------------
>
> Key: CALCITE-5262
> URL: https://issues.apache.org/jira/browse/CALCITE-5262
> Project: Calcite
> Issue Type: Bug
> Components: spatial
> Reporter: Julian Hyde
> Assignee: Bertil Chapuis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add functions to support WKB (well-known binary) and GeoJSON. This is made
> possible by the switch to JTS in CALCITE-4294. The functions are:
> * ST_AsEWKT
> * ST_AsGeoJSON
> * ST_AsWKB
> * ST_GeomFromGeoJSON
> * ST_GeomFromWKB
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
