[
https://issues.apache.org/jira/browse/CALCITE-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602045#comment-17602045
]
Julian Hyde commented on CALCITE-5262:
--------------------------------------
It's OK to base the tests on H2GIS documentation. I did the same thing. I did
not use the H2GIS implementation, because H2GIS's license does not allow that.
It's OK if the tests do not cover the corner cases. Following the 'release
often' principle, let's put the functions out there, and if people use them,
they can log bugs.
The 'compatibility' column in [the
reference|https://calcite.apache.org/docs/reference.html#spatial-functions]
just indicates which specification the function originated. If a function
originated in OpenGIS and the implementations in PostGIS and H2GIS differ, we
would still flag it 'o'.
If there are differences, we should try to implement the 'better' one. We
should try not to innovate, even if we believe that our specification is
'better' than other systems; I believe that people want consistency with
standards, and they like being able to read other systems' documentation and
apply what they learned in Calcite.
We can of course invent our own functions, if there is a significant benefit,
as long as we fully document them and clearly mark them as Calcite extensions.
But Calcite's strategy is generally to innovate in implementation, not in
specification.
I plan to merge your PR shortly.
> Add functions to support WKB (well-known binary) and GeoJSON
> ------------------------------------------------------------
>
> Key: CALCITE-5262
> URL: https://issues.apache.org/jira/browse/CALCITE-5262
> Project: Calcite
> Issue Type: Bug
> Components: spatial
> Reporter: Julian Hyde
> Assignee: Bertil Chapuis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add functions to support WKB (well-known binary) and GeoJSON. This is made
> possible by the switch to JTS in CALCITE-4294. The functions are:
> * ST_AsEWKT
> * ST_AsGeoJSON
> * ST_AsWKB
> * ST_GeomFromGeoJSON
> * ST_GeomFromWKB
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
