[ 
https://issues.apache.org/jira/browse/CALCITE-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680068#comment-17680068
 ] 

Oliver Lee commented on CALCITE-5180:
-------------------------------------

Hey [~julianhyde] 

PR ready here: [https://github.com/olivrlee/calcite/pull/3] 

this PR is part 3 of isolating Will's work on your dev branch 
[here|https://github.com/apache/calcite/pull/3023]

 

Review order should be:

1) CALCITE-5424  [Custom literals 
PR|https://github.com/apache/calcite/pull/3036] 

2)  CALCITE-5446 [TIMESTAMP_WITH_LOCAL_TIMEZONE 
PR|https://github.com/olivrlee/calcite/pull/2]

3) This ticket  CALCITE-5180  [PR|https://github.com/olivrlee/calcite/pull/3]

 

After review I plan on squashing these 3 into 1 PR with 3 commits and merge 
that 

> Implement BigQuery functions for DATE, TIME, TIMESTAMP, DATETIME
> ----------------------------------------------------------------
>
>                 Key: CALCITE-5180
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5180
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Will Noble
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> Implement missing BigQuery functions for DATE, TIME, TIMESTAMP, DATETIME.
> Functions include:
> * CURRENT_DATE, CURRENT_DATETIME, CURRENT_TIME with timezone;
> * EXTRACT with time unit values WEEK(weekday), DATE, TIME;
> * various DATE, TIME, TIMESTAMP, DATETIME constructor functions;
> * DATE_ADD, DATETIME_ADD, TIME_ADD, TIMESTAMP_ADD;
> * DATE_SUB, DATETIME_SUB, TIME_SUB, TIMESTAMP_SUB;
> * DATE_DIFF, DATETIME_DIFF, TIME_DIFF, TIMESTAMP_DIFF;
> * DATE_TRUNC, DATETIME_TRUNC, TIME_TRUNC, TIMESTAMP_TRUNC;
> * LAST_DAY;
> * FORMAT_DATE, FORMAT_DATETIME, FORMAT_TIME, FORMAT_TIMESTAMP; 
> * PARSE_DATE, PARSE_DATETIME, PARSE_TIME, PARSE_TIMESTAMP. 
> The following functions are already implemented: CURRENT_DATETME, 
> DATE(string), DATE_FROM_UNIX_DATE, TIMESTAMP_MICROS, TIMESTAMP_MILLIS, 
> TIMESTAMP_SECONDS, UNIX_MICROS, UNIX_MILLIS, UNIX_SECONDS, UNIX_DATE.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to