[
https://issues.apache.org/jira/browse/CALCITE-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707457#comment-17707457
]
Julian Hyde commented on CALCITE-5624:
--------------------------------------
The current PR is what I call a "drill a hole" change. It does not benefit
Calcite very much, but it presumably allows you to achieve your project's goals
with a derived parser. Presumably you have implemented 'array' and 'map'
functions in your project. Presumably you have written tests in your project,
but you have not contributed them here.
"Drill a hole" changes are problematic because they do not benefit Calcite very
much, but if we were to remove or accidentally break your functionality in
future you would complain.
Please, let's realign this change into something that adds value for all
Calcite users.
> Cannot parse array function for Spark Dialect
> ---------------------------------------------
>
> Key: CALCITE-5624
> URL: https://issues.apache.org/jira/browse/CALCITE-5624
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.34.0
> Reporter: Guillaume Massé
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> AtomicRowExpression should not have ArrayConstructor for Apache Spark. Arrays
> are constructed by calling the array function
> ([https://spark.apache.org/docs/latest/api/sql/index.html#array]).
>
> {code:java}
> array()
> array(1)
> array(1, 2, 3){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
